[SDK] Fix updateListing date handling in marketplace direct listings #6628

joaquim-verges · 2025-04-02T22:17:48Z

Fixes TOOL-3924

PR-Codex overview

This PR focuses on fixing the handling of date timestamps in the updateListing function within the thirdweb package, ensuring correct validation and assignment of start and end timestamps.

Detailed summary

Updated startTimestamp and endTimestamp assignment logic in updateListing.ts to handle cases with mergedOptions.
Added validation to ensure startTimestamp is before endTimestamp.
Introduced a test case for updateListing in direct-listings.test.ts.
Adjusted expected values for secondListing in the test to reflect the new price.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-04-02T22:17:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 2, 2025 10:40pm
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 2, 2025 10:40pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 2, 2025 10:40pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 2, 2025 10:40pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 2, 2025 10:40pm

changeset-bot · 2025-04-02T22:17:51Z

🦋 Changeset detected

Latest commit: 22dc69a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

joaquim-verges · 2025-04-02T22:18:03Z

[SDK] Fix updateListing date handling in marketplace direct listings #6628 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

linear · 2025-04-02T22:18:19Z

TOOL-3924 Invalid enforced condition in updateListing extension

packages/thirdweb/src/extensions/marketplace/direct-listings/write/updateListing.ts

github-actions · 2025-04-02T22:25:18Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	47.49 KB (0%)	950 ms (0%)	1.7 s (+7.5% 🔺)	2.6 s
thirdweb (cjs)	129.89 KB (0%)	2.6 s (0%)	4.4 s (+6.22% 🔺)	7 s
thirdweb (minimal + tree-shaking)	5.62 KB (0%)	113 ms (0%)	225 ms (+105.01% 🔺)	337 ms
thirdweb/chains (tree-shaking)	514 B (0%)	11 ms (0%)	37 ms (-2.4% 🔽)	47 ms
thirdweb/react (minimal + tree-shaking)	19.33 KB (0%)	387 ms (0%)	549 ms (+80.23% 🔺)	936 ms

codecov · 2025-04-02T22:26:17Z

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (5faaf1b) to head (22dc69a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...marketplace/direct-listings/write/updateListing.ts	28.57%	10 Missing ⚠️

❌ Your patch status has failed because the patch coverage (28.57%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6628      +/-   ##
==========================================
+ Coverage   54.96%   54.97%   +0.01%     
==========================================
  Files         887      888       +1     
  Lines       55652    55752     +100     
  Branches     3798     3817      +19     
==========================================
+ Hits        30591    30652      +61     
- Misses      24966    25005      +39     
  Partials       95       95

Flag	Coverage Δ
packages	`54.97% <28.57%> (+0.01%)`	⬆️

Files with missing lines	Coverage Δ
...marketplace/direct-listings/write/updateListing.ts	`61.00% <28.57%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graphite-app · 2025-04-02T22:29:42Z

packages/thirdweb/src/extensions/marketplace/direct-listings/write/updateListing.ts

+
+      if (
+        startTimestamp !== mergedOptions.startTimeInSeconds &&
+        startTimestamp <= lastestBlock.timestamp


There appears to be a typo in the variable name lastestBlock which should be latestBlock. This typo occurs in multiple places throughout the conditional checks in the date validation logic.

Suggested change

startTimestamp <= lastestBlock.timestamp

startTimestamp <= latestBlock.timestamp

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

github-actions bot added the packages label Apr 2, 2025

github-actions bot assigned joaquim-verges Apr 2, 2025

github-actions bot added the SDK Involves changes to the thirdweb SDK label Apr 2, 2025

joaquim-verges changed the title ~~Fix updateListing date handling in marketplace direct listings~~ [SDK] Fix updateListing date handling in marketplace direct listings Apr 2, 2025

joaquim-verges marked this pull request as ready for review April 2, 2025 22:18

joaquim-verges requested review from a team as code owners April 2, 2025 22:18

joaquim-verges force-pushed the Fix_updateListing_date_handling_in_marketplace_direct_listings branch from ba79d2d to 722da03 Compare April 2, 2025 22:18

joaquim-verges mentioned this pull request Apr 2, 2025

Invalid enforced condition in updateListing extension #6622

Closed

joaquim-verges force-pushed the Fix_updateListing_date_handling_in_marketplace_direct_listings branch from 722da03 to 21f51ba Compare April 2, 2025 22:20

joaquim-verges mentioned this pull request Apr 2, 2025

Missing export for ERC721 getApproved #6623

Closed

graphite-app bot reviewed Apr 2, 2025

View reviewed changes

packages/thirdweb/src/extensions/marketplace/direct-listings/write/updateListing.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview – login April 2, 2025 22:24 View deployment

vercel bot deployed to Preview – wallet-ui April 2, 2025 22:25 View deployment

vercel bot deployed to Preview – thirdweb_playground April 2, 2025 22:26 View deployment

Fix updateListing date handling in marketplace direct listings

22dc69a

joaquim-verges force-pushed the Fix_updateListing_date_handling_in_marketplace_direct_listings branch from 21f51ba to 22dc69a Compare April 2, 2025 22:29

graphite-app bot reviewed Apr 2, 2025

View reviewed changes

vercel bot deployed to Preview – wallet-ui April 2, 2025 22:31 View deployment

vercel bot deployed to Preview – login April 2, 2025 22:31 View deployment

vercel bot deployed to Preview – thirdweb_playground April 2, 2025 22:32 View deployment

vercel bot deployed to Preview – thirdweb-www April 2, 2025 22:36 View deployment

vercel bot deployed to Preview – docs-v2 April 2, 2025 22:40 View deployment

joaquim-verges merged commit 95a8753 into main Apr 2, 2025
32 of 33 checks passed

joaquim-verges deleted the Fix_updateListing_date_handling_in_marketplace_direct_listings branch April 2, 2025 23:27

joaquim-verges mentioned this pull request Apr 2, 2025

Version Packages #6620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix updateListing date handling in marketplace direct listings #6628

[SDK] Fix updateListing date handling in marketplace direct listings #6628

Uh oh!

joaquim-verges commented Apr 2, 2025 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

joaquim-verges commented Apr 2, 2025

Uh oh!

linear bot commented Apr 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

graphite-app bot Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	startTimestamp <= lastestBlock.timestamp
	startTimestamp <= latestBlock.timestamp

[SDK] Fix updateListing date handling in marketplace direct listings #6628

[SDK] Fix updateListing date handling in marketplace direct listings #6628

Uh oh!

Conversation

joaquim-verges commented Apr 2, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

joaquim-verges commented Apr 2, 2025

How to use the Graphite Merge Queue

Uh oh!

linear bot commented Apr 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaquim-verges commented Apr 2, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Apr 2, 2025 •

edited

Loading

changeset-bot bot commented Apr 2, 2025 •

edited

Loading

github-actions bot commented Apr 2, 2025 •

edited

Loading

codecov bot commented Apr 2, 2025 •

edited

Loading